Move getTypeForMangling() to AST #20252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
move-get-type-for-mangling-to-ast
branch
from
8a98b25 to
4fb5ccf
Compare
|
@swift-ci Please smoke test |
|
apple/swift-lldb#1027 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I defined this in RemoteAST to begin with because it used the RemoteASTTypeBuilder class defined in the same file. However this class does not depend on the rest of RemoteAST, so let's move it to include/swift/AST/ASTDemangler.h, to go with ASTMangler.h. This means that SourceKit can now use getTypeForMangling() without depending on RemoteAST (and IRGen).