Skip to content

Cosmetics (NFC) #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions include/swift/Subsystems.h
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ namespace swift {
/// compilation.
bool shouldVerify(const Decl *D, const ASTContext &Context);

/// \brief Check that the source file is well formed, aborting and spewing
/// \brief Check that the source file is well-formed, aborting and spewing
/// errors if not.
///
/// "Well-formed" here means following the invariants of the AST, not that the
Expand Down Expand Up @@ -232,28 +232,24 @@ namespace swift {

/// Turn the given Swift module into either LLVM IR or native code
/// and return the generated LLVM IR module.
std::unique_ptr<llvm::Module> performIRGeneration(IRGenOptions &Opts,
ModuleDecl *M,
SILModule *SILMod,
StringRef ModuleName,
llvm::LLVMContext &LLVMContext);
std::unique_ptr<llvm::Module>
performIRGeneration(IRGenOptions &Opts, ModuleDecl *M, SILModule *SILMod,
StringRef ModuleName, llvm::LLVMContext &LLVMContext);

/// Turn the given Swift module into either LLVM IR or native code
/// and return the generated LLVM IR module.
std::unique_ptr<llvm::Module> performIRGeneration(IRGenOptions &Opts,
SourceFile &SF,
SILModule *SILMod,
StringRef ModuleName,
llvm::LLVMContext &LLVMContext,
unsigned StartElem = 0);
std::unique_ptr<llvm::Module>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you see what clang-format does on this text? Try using git-clang-format. Many of us use that as our baseline of changes like this, so matching what clang-format does will reduce future changes by clang-format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, fixed according to git-clang-format

performIRGeneration(IRGenOptions &Opts, SourceFile &SF, SILModule *SILMod,
StringRef ModuleName, llvm::LLVMContext &LLVMContext,
unsigned StartElem = 0);

/// Given an already created LLVM module, construct a pass pipeline and run
/// the Swift LLVM Pipeline upon it. This does not cause the module to be
/// printed. Only optimized.
/// printed, only to be optimized.
void performLLVMOptimizations(IRGenOptions &Opts, llvm::Module *Module,
llvm::TargetMachine *TargetMachine);

/// Wrap a serialized module inside a swift ast section in an object file.
/// Wrap a serialized module inside a swift AST section in an object file.
void createSwiftModuleObjectFile(SILModule &SILMod, StringRef Buffer,
StringRef OutputPath);

Expand Down Expand Up @@ -284,4 +280,4 @@ namespace swift {

} // end namespace swift

#endif
#endif // SWIFT_SUBSYSTEMS_H