Always manage subobject projections with formal-access cleanups #20306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I haven't actually tested this separately from the changes to scope usage that are coming in the follow-up, but it's logically somewhat separate.
|
@swift-ci Please test. |
|
Build failed |
To make that work, enter appropriate scopes (ArgumentScopes and FormalEvaluationScopes) at a bunch of places. But note that l-value emission generally can't enter such a scope, so in generic routines like emitOpenExistentialExpr we have to just assert that we're already in a scope.
rjmccall
force-pushed
the
projection-formal-accesses
branch
from
3b76dad to
7da688d
Compare
|
@swift-ci Please test. |
|
Build failed |
|
Build failed |
|
Looks like the bots are completely busted. |
|
@swift-ci test |
|
Build failed |
|
@rjmccall I think the linux builds are fixed now. The OS X I believe is borked due to this blame list: https://ci.swift.org/job/oss-swift-incremental-RA-osx/5513/ Something in clang. I may try to do some reverts. |
|
@swift-ci Please clean test OS X. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.