[Runtime] Diagnose multiple retroactive conformances for X: P. #20322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thread a module name into the protocol conformance lookup function
(e.g., the function implementing swift_conformsToProtocol), and compare that
against the module context of retroactive conformances. When we don’t care
where we find the resulting conformance (e.g., the module name is NULL),
and more than one retroactive conformance found, produce a warning like this:
***Swift runtime warning: multiple conformances for
'RetroactiveCommon.CommonStruct: CommonP1' found in modules
'RetroactiveA' and 'RetroactiveB'. Arbitrarily selecting conformance
from module 'RetroactiveA'
This code will also be used to select specific conformances.
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please smoke test Linux |
|
@swift-ci please test Linux |
|
Build failed |
|
I'm pulling this into #20424. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread a module name into the protocol conformance lookup function
(e.g., the function implementing swift_conformsToProtocol), and compare that
against the module context of retroactive conformances. When we don’t care
where we find the resulting conformance (e.g., the module name is NULL),
and more than one retroactive conformance found, produce a warning like this:
This code will also be used to select specific conformances.