[String] Add _CocoaString typealias to all build configurations. #20338
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test and merge |
stephentyrone
approved these changes
Nov 5, 2018
|
What could possibly go wrong? |
jrose-apple
reviewed
Nov 5, 2018
| @@ -12,14 +12,14 @@ | |||
|
|
|||
| import SwiftShims | |||
|
|
|||
| /// Effectively an untyped NSString that doesn't require foundation. | |||
| public typealias _CocoaString = AnyObject | |||
There was a problem hiding this comment.
Maybe it can be @usableFromInline internal now?
Conditionally compiling out _CocoaString from 32-bit string will be way too unweidly. Fixes Android bots.
|
@swift-ci please smoke test os x platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally compiling out _CocoaString from 32-bit string will be
way too unweidly. Fixes Android bots.