Skip to content

[Tests] Add tests for unary operators on tuples #20346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2018
Merged

[Tests] Add tests for unary operators on tuples #20346

merged 1 commit into from
Nov 7, 2018

Conversation

AnthonyLatsis
Copy link
Collaborator

Adds tests for SR-294, resolved in #19580

@slavapestov

slavapestov
slavapestov reviewed Nov 6, 2018
View reviewed changes
Copy link
Contributor

@slavapestov slavapestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be incorporated into an existing test file. Otherwise looks good.

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Nov 6, 2018 •
edited
Loading

I tried to find a file with a similar "theme" in Sema, but they all seem off the subject to me. How about /expr/expressions.swift?

@slavapestov
Copy link
Contributor

How about test/decl/func/operator.swift?

@AnthonyLatsis AnthonyLatsis force-pushed the tests-unary-operators-on-tuples branch from f6a8a8c to 555414a Compare November 6, 2018 22:35
@slavapestov
Copy link
Contributor

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor

Linux failure isn't you:

00:26:12 ********************
00:26:12 Testing Time: 14.29s
00:26:12 ********************
00:26:12 Failing Tests (1):
00:26:12     SwiftXCTestFunctionalTests :: Asynchronous/Expectations/main.swift

@slavapestov
Copy link
Contributor

@swift-ci Please smoke test Linux

@slavapestov slavapestov self-assigned this Nov 7, 2018
@AnthonyLatsis
Copy link
Collaborator Author

Does it fail from time to time?

@slavapestov slavapestov merged commit 9b2cc22 into swiftlang:master Nov 7, 2018
@AnthonyLatsis AnthonyLatsis deleted the tests-unary-operators-on-tuples branch November 8, 2018 03:35
@AnthonyLatsis AnthonyLatsis mentioned this pull request Nov 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov left review comments

Assignees

@slavapestov slavapestov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyLatsis @slavapestov