[test] un-XFAIL passing parse_stdlib test. #20356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problematic class no longer exists, so the test passes.
|
@swift-ci please smoke test and merge |
|
Merging to unblock bots |
|
Yippee! |
Any idea what was so offensive about the old class? Bug is still there, I just removed the code that triggered it |
|
It's a bug in SIL round-tripping that requires that we do some straightforward-but-annoying changes to textual SIL to make declaration references to functions include argument labels. I'm happy because this test generally provides value, but has had to be disabled for a while, and I've been fighting (unrelated) regressions over the last few months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problematic class no longer exists, so the test passes.