Skip to content

[RemoteMirror] Update interop to handle 4.2 libraries. #20363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 26, 2018
Merged

[RemoteMirror] Update interop to handle 4.2 libraries. #20363

merged 3 commits into from
Nov 26, 2018

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Nov 6, 2018

The Remote Mirror interop header now accepts an arbitrary number of remote mirror libraries so that it can have 4.1, 4.2, and 5.0 loaded side by side.

rdar://problem/45808282

@mikeash mikeash force-pushed the remote-mirror-interop-for-4.2 branch from 7872eed to a83bea8 Compare November 8, 2018 19:46
@mikeash
Copy link
Contributor Author

mikeash commented Nov 15, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a83bea8fef4c2a6594f7811bb2e721e97bd23dee

@mikeash
Copy link
Contributor Author

mikeash commented Nov 16, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a83bea8fef4c2a6594f7811bb2e721e97bd23dee

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a83bea8fef4c2a6594f7811bb2e721e97bd23dee

@mikeash mikeash force-pushed the remote-mirror-interop-for-4.2 branch from 9917d26 to d057b8a Compare November 16, 2018 17:47
@mikeash
Copy link
Contributor Author

mikeash commented Nov 16, 2018

@swift-ci

@mikeash
Copy link
Contributor Author

mikeash commented Nov 16, 2018

@swift-ci please smoke test and merge

@mikeash
[RemoteMirror] Update interop to handle 4.2 libraries.
47be50c 
The Remote Mirror interop header now accepts an arbitrary number of remote mirror libraries so that it can have 4.1, 4.2, and 5.0 loaded side by side.

rdar://problem/45808282
@mikeash
[RemoteMirror] Fix various interop warnings in the headers.
7c93881
@mikeash
[RemoteMirror] Fix lint errors in RemoteMirrorInterop/test.py, and ma…
4ae12f3 
…ke relative path args work when the working directory is not the script's enclosing directory.
@mikeash mikeash force-pushed the remote-mirror-interop-for-4.2 branch from d057b8a to 4ae12f3 Compare November 26, 2018 16:12
@mikeash
Copy link
Contributor Author

mikeash commented Nov 26, 2018

@swift-ci please smoke test and merge

1 similar comment
@mikeash
Copy link
Contributor Author

mikeash commented Nov 26, 2018

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit ae9f1b1 into swiftlang:master Nov 26, 2018
@alexander-shaposhnikov
Copy link

alexander-shaposhnikov commented Mar 25, 2019 •
edited
Loading

@mikeash Sorry about the disturbance, if I'm not mistaken the script test.py refers to the source file test.swift
(it looks like the old files test4.swift, test5.swift were removed in 47be50c#diff-fec5f6f30e172e9e11d336da7526c693 ), but I don't see test.swift (even on the master branch) anywhere, has it been committed / removed separately for some reason or maybe I'm missing something ? cc: @compnerd

@mikeash
Copy link
Contributor Author

mikeash commented Mar 26, 2019

Good catch! I apparently just missed adding the file to git. Fortunately I still have it locally, so I was able to add it in. Here's the PR with it: #23556

Thank you for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeash @swift-ci @alexander-shaposhnikov