[SourceKit/SwiftLang] Keep sourcekitd response alive for variant lifetime #20370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 6, 2018 13:19
…tdResponse context sourcekitd_variant_t is only safe to use while the sourcekitd_response_t it was retrieved from is still alive, so keep a strong reference to SourceKitdResponse (the Swift wrapper of sourcekitd_response_t) in each Variant (the Swift wrapper of sourcekitd_variant_t).
…wrapper These were recently added to support returning the SyntaxTree in the bytetree from SourceKit but were never added in SwiftLang (the Swift layer wrapping SourceKit).
|
@swift-ci please test |
nkcsgexi
approved these changes
Nov 6, 2018
|
Could we also cherry-pick this to swift-5.0-branch afterwards? It's useful to verify syntax tree binary format in a toolchain. |
nkcsgexi
reviewed
Nov 6, 2018
nathawes
deleted the
keep-sourcekitd-response-alive-for-variant-lifetime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes to SwiftLang, the Swift layer exposing SourceKit in Swift:
SourceKitdResponsecontext. This is needed becausesourcekitd_variant_tis only safe to use while thesourcekitd_response_tit was retrieved from (wrapped bySourceKitdResponse) is still alive.Datavariant SourceKit APIs that were added to support returning the Syntax tree in a binary format in SwiftLang.