[5.0][incrParse] A couple of fixes for incrParse #20391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the position is in the region that is inserted by the edits, 'pre-edit' position shouldn't exist. So we cannot reuse the node at the position. rdar://problem/45259469 https://bugs.swift.org/browse/SR-8995
Taking Missing node into account confuses reusability checking in incremental parsing. rdar://problem/45215049 https://bugs.swift.org/browse/SR-8976 rdar://problem/45287031 https://bugs.swift.org/browse/SR-9006
|
@swift-ci Please test |
|
Build failed |
|
The linux failure is unrelated. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of a couple of fixes for incremental parsing.
Skip missing node in getNextNode() [incrParse] Skip missing node in SyntaxData::getNextNode() #19951
Taking Missing node into account confuses reusability checking in incremental parsing.
rdar://problem/45215049 https://bugs.swift.org/browse/SR-8976
rdar://problem/45287031 https://bugs.swift.org/browse/SR-9006
Fix SyntaxParsingCache::translateToPreEditPosition() [incrParse] Fix SyntaxParsingCache::translateToPreEditPosition() #20321
If the position is in the region that is inserted by the edits, 'pre-edit' position shouldn't exist. So we cannot reuse the node at the position.
rdar://problem/45259469 https://bugs.swift.org/browse/SR-8995