Finish removing -swift-version 3 #20409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completes <rdar://problem/43101816>.
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
dnadoba
requested changes
Nov 7, 2018
| @@ -153,7 +153,7 @@ class Version { | |||
| // List of backward-compatibility versions that we permit passing as | |||
| // -swift-version <vers> | |||
| static std::array<StringRef, 4> getValidEffectiveVersions() { | |||
There was a problem hiding this comment.
Array size should be 3 instead of 4
Suggested change
| static std::array<StringRef, 4> getValidEffectiveVersions() { | |
| static std::array<StringRef, 3> getValidEffectiveVersions() { |
|
See also #20374 |
|
Oops, I didn't realize we made the same change here. @tkremenek The only significant difference I see is that I removed the swift3 lit substitutions from lit.cfg, and XFAILd the offending tests. Do you want to take over? |
|
Yeah I'll take over. |
|
Thanks Ted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/43101816.