Skip to content

Use @_borrowed on a few declarations in the stdlib and overlays #20415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2018
Merged

Use @_borrowed on a few declarations in the stdlib and overlays #20415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87e9fb5
Use @_borrowed on a few declarations in the stdlib and overlays.
rjmccall Nov 7, 2018
d339eab
Don't apply the -Osize heuristic when inlining coroutines.
rjmccall Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/SILOptimizer/Transforms/PerformanceInliner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,12 @@ bool SILPerformanceInliner::isProfitableToInline(
int BaseBenefit = RemovedCallBenefit;

// Osize heuristic.
//
// As a hack, don't apply this at all to coroutine inlining; avoiding
// coroutine allocation overheads is extremely valuable. There might be
// more principled ways of getting this effect.
bool isClassMethodAtOsize = false;
if (OptMode == OptimizationMode::ForSize) {
if (OptMode == OptimizationMode::ForSize && !isa<BeginApplyInst>(AI)) {
// Don't inline into thunks.
if (AI.getFunction()->isThunk())
return false;
Expand Down
9 changes: 5 additions & 4 deletions stdlib/public/SDK/CoreAudio/CoreAudio.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,16 +151,17 @@ extension UnsafeMutableAudioBufferListPointer
}

/// Access an indexed `AudioBuffer` (`mBuffers[i]`).
@_borrowed
public subscript(index: Index) -> Element {
get {
_read {
precondition(index >= 0 && index < self.count,
"subscript index out of range")
return (_audioBuffersPointer + index).pointee
yield ((_audioBuffersPointer + index).pointee)
}
nonmutating set(newValue) {
nonmutating _modify {
precondition(index >= 0 && index < self.count,
"subscript index out of range")
(_audioBuffersPointer + index).pointee = newValue
yield (&(_audioBuffersPointer + index).pointee)
}
}
}
Expand Down
1 change: 1 addition & 0 deletions stdlib/public/core/Collection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,7 @@ public protocol Collection: Sequence where SubSequence: Collection {
/// `endIndex` property.
///
/// - Complexity: O(1)
@_borrowed
subscript(position: Index) -> Element { get }

/// Accesses a contiguous subrange of the collection's elements.
Expand Down
1 change: 1 addition & 0 deletions stdlib/public/core/MutableCollection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ where SubSequence: MutableCollection
/// `endIndex` property.
///
/// - Complexity: O(1)
@_borrowed
override subscript(position: Index) -> Element { get set }

/// Accesses a contiguous subrange of the collection's elements.
Expand Down