Skip to content

Add -lm to Glibc.modulemap on Linux #20430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2018
Merged

Add -lm to Glibc.modulemap on Linux #20430

merged 1 commit into from
Nov 9, 2018

Conversation

alblue
Copy link
Contributor

@alblue alblue commented Nov 8, 2018

Unlike Darwin, on Linux when using functions from math.h the m library
needs to be added to the compilation. This should be explicit in the
module map, rather than being implicit in the driver.

Resolves SR-9198.

@alblue
Add -lm to Glibc.modulemap on Linux
0ee1d78 
Unlike Darwin, on Linux when using functions from math.h the m library
needs to be added to the compilation. This should be explicit in the
module map, rather than being implicit in the driver.

Fixes SR-9198
@alblue
Copy link
Contributor Author

alblue commented Nov 8, 2018

@swift-ci please test

@alblue
Copy link
Contributor Author

alblue commented Nov 8, 2018

@swift-ci please smoke test

@alblue alblue requested a review from airspeedswift November 8, 2018 17:07
@airspeedswift airspeedswift requested review from stephentyrone and removed request for airspeedswift November 8, 2018 17:17
@swift-ci
Copy link
Contributor

swift-ci commented Nov 8, 2018

Build failed
Swift Test Linux Platform
Git Sha - 0ee1d78

@alblue
Copy link
Contributor Author

alblue commented Nov 8, 2018

Some kind of asynchronous test failure issue?

12:23:11 Test Case 'ExpectationsTestCase.test_waitingForAnUnfulfilledExpectation_fails' started at 2018-11-08 12:22:53.780
12:23:11 
/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swift-corelibs-xctest/Tests/Functional/Asynchronous/Expectations/main.swift:23: error: ExpectationsTestCase.test_waitingForAnUnfulfilledExpectation_fails : Asynchronous wait failed - Exceeded timeout of 0.2 seconds, with unfulfilled expectations: foo

@swift-ci please test linux

@alblue
Copy link
Contributor Author

alblue commented Nov 8, 2018

@swift-ci please smoke test macos

@alblue
Copy link
Contributor Author

alblue commented Nov 8, 2018

This is being reported elsewhere as well, so I think it is unrelated to this change

rdar://45891030

@swift-ci
Copy link
Contributor

swift-ci commented Nov 8, 2018

Build failed
Swift Test Linux Platform
Git Sha - 0ee1d78

@alblue
Copy link
Contributor Author

alblue commented Nov 9, 2018

@swift-ci please test linux

@alblue alblue merged commit f0f48e5 into swiftlang:master Nov 9, 2018
@alblue alblue mentioned this pull request Nov 8, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentyrone stephentyrone stephentyrone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alblue @swift-ci @stephentyrone