[ParseableInterfaces] Handle unsatisfiable conditional conformances #20433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
harlanhaskins
approved these changes
Nov 8, 2018
|
Build failed |
...by printing them with a dummy, unsatisfiable condition. This happens when a public type conforms to a public protocol with non-public conditions; the conformance can't be used in inlinable code, but neither is it okay for a client to declare their own conformance (constrained or unconstrained). rdar://problem/45657450
jrose-apple
force-pushed
the
another-unsatisfied-customer
branch
from
39fbb26 to
3235fb2
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by printing them with a dummy, unsatisfiable condition. This happens when a public type conforms to a public protocol with non-public conditions; the conformance can't be used in inlinable code, but neither is it okay for a client to declare their own conformance (constrained or unconstrained).
rdar://problem/45657450. See also the forum thread at https://forums.swift.org/t/parseable-interfaces-conditional-conformances-with-non-public-conditions-are-problematic/17747/.