Skip to content

[stdlib] Remove last addressWithNativeOwner use #20448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

airspeedswift
Copy link
Member

Replace with _read

@airspeedswift
Copy link
Member Author

@swift-ci please benchmark

@airspeedswift
Copy link
Member Author

@swift-ci please test

@slavapestov
Copy link
Contributor

Sweet

@airspeedswift
Copy link
Member Author

pls to not jinx the benchmarks

@swift-ci
Copy link
Contributor

swift-ci commented Nov 9, 2018

Build comment file:

Performance: -O

TEST OLD NEW DELTA RATIO
Regression
StringEqualPointerComparison 600 657 +9.5% 0.91x

Performance: -Osize

TEST OLD NEW DELTA RATIO
Regression
StringEqualPointerComparison 571 628 +10.0% 0.91x

Performance: -Onone

TEST OLD NEW DELTA RATIO
Improvement
ArrayOfGenericPOD2 1180 1066 -9.7% 1.11x (?)
ArrayOfPOD 859 778 -9.4% 1.10x
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB
--------------

@slavapestov
Copy link
Contributor

Good enough, ship it

@airspeedswift
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 9, 2018

Build failed
Swift Test OS X Platform
Git Sha - 7c60187

@airspeedswift airspeedswift merged commit 6aab1c8 into swiftlang:master Nov 9, 2018
@airspeedswift airspeedswift deleted the address-with-owner branch November 15, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants