Always use the l-value logic for emitting key path applications #20459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not NFC because it also fixes an evaluation order bug (and reorders some less-important stuff): the key-path expression needs to be evaluated immediately during formal evaluation and cannot be delayed until start-of-access.
|
@swift-ci Please test. |
|
Makes sense, thanks John! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not NFC because it also fixes an evaluation order bug (and reorders some less-important stuff): the key-path expression needs to be evaluated immediately during formal evaluation and cannot be delayed until start-of-access.