Skip to content

Fix links in ABI Stability Manifesto #20460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Conversation

MaxDesiatov
Copy link
Contributor

Currently links to ABI docs lead to a 404 page https://github.com/apple/swift/blob/master/docs/ABI.rst. As far as I understand that document was previously split and the linked parts were moved https://github.com/apple/swift/blob/master/docs/ABI/ directory, but the links to it weren't updated. This PR fixes the links.

Currently links to ABI docs lead to a 404 page https://github.com/apple/swift/blob/master/docs/ABI.rst. As far as I understand that document was previously split and the linked parts were moved https://github.com/apple/swift/blob/master/docs/ABI/ directory, but the links to it weren't updated. This PR fixes the links.
@MaxDesiatov MaxDesiatov changed the title Fixed links in ABI Stability Manifesto Fix links in ABI Stability Manifesto Nov 9, 2018
@spevans
Copy link
Contributor

spevans commented Nov 9, 2018

@swift-ci Please smoke test

1 similar comment
@xwu
Copy link
Collaborator

xwu commented Nov 10, 2018

@swift-ci Please smoke test

@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Nov 13, 2018

@milseman since you're the original author of "ABI Stability Manifesto" that's being updated here, could you please have a look at this PR? Thank you!

@jrose-apple
Copy link
Contributor

This seems straightforward to me. Thanks, Max!

@jrose-apple jrose-apple merged commit c266662 into swiftlang:master Nov 13, 2018
@milseman
Copy link
Member

LGTM, thanks for catching this!

@MaxDesiatov MaxDesiatov deleted the patch-1 branch April 28, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants