[LangOptions] os(Cygwin) is not true on Cygwin #20469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this? |
`Target.isOSWindows()` and `Target.isWindowsCygwinEnvironment()` are both true in Cygwin. We should check the `os(Cygwin)` before `os(Windows)`.
tinysun212
force-pushed
the
pr-os-macro-cygwin-2
branch
from
7ba6028 to
859f144
Compare
|
@harlanhaskins I amended the commit. |
compnerd
approved these changes
Nov 12, 2018
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target.isOSWindows()andTarget.isWindowsCygwinEnvironment()are both true in Cygwin.We should check the
os(Cygwin)beforeos(Windows).