Skip to content

[stdlib] Expunge FixedArray from ABI #20480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Conversation

milseman
Copy link
Member

@milseman milseman commented Nov 9, 2018

No description provided.

@milseman
Copy link
Member Author

milseman commented Nov 9, 2018

@swift-ci please benchmark

@milseman
Copy link
Member Author

milseman commented Nov 9, 2018

@swift-ci please smoke test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 9, 2018

Build comment file:

Performance: -Onone

TEST OLD NEW DELTA RATIO
Regression
DropFirstArrayLazy 31975 35208 +10.1% 0.91x
PrefixArrayLazy 31857 35032 +10.0% 0.91x
DropLastArrayLazy 10638 11696 +9.9% 0.91x
SuffixArrayLazy 10629 11599 +9.1% 0.92x
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB
--------------

@milseman milseman merged commit b19f8cc into swiftlang:master Nov 10, 2018
@milseman milseman deleted the fixed_nixed branch November 10, 2018 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants