[test] @objc optional should always use a dynamic dispatch #20487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
slavapestov
approved these changes
Nov 9, 2018
|
Build failed |
Right now we're not being careful about 'optional' in witness tables for parseable interfaces; we're listing the requirement as the implementation even if the requirement is optional. As long as we don't optimize based on that information, though, we should be okay.
jrose-apple
force-pushed
the
always-nice-to-have-options
branch
from
316d557 to
bc80b1f
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we're not being careful about 'optional' in witness tables for parseable interfaces; we're listing the requirement as the implementation even if the requirement is optional. As long as we don't optimize based on that information, though, we should be okay.