Skip to content

[WIP][stdlib] Audit inlinability in BridgeObjectiveC (take 2) #20489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Nov 10, 2018

Version of #20470

rdar://problem/45949961

@moiseev
Copy link
Contributor Author

moiseev commented Nov 10, 2018

@swift-ci Please benchmark

@swift-ci
Copy link
Contributor

Build comment file:

Performance: -O

TEST OLD NEW DELTA RATIO
Regression
ArrayLiteral 0 1289 +128900000.0% 0.00x
StringEnumRawValueInitialization 1303 17531 +1245.4% 0.07x
COWArrayGuaranteedParameterOverhead 11217 15409 +37.4% 0.73x
ObjectiveCBridgeFromNSDictionaryAnyObject 102209 133422 +30.5% 0.77x
DataCreateSmallArray 30756 38668 +25.7% 0.80x
DataCreateMediumArray 3147 3937 +25.1% 0.80x
ChainedFilterMap 1214 1404 +15.7% 0.86x (?)
MapReduceShortString 17 19 +11.8% 0.89x
StackPromo 16716 18289 +9.4% 0.91x
FlattenListLoop 3972 4339 +9.2% 0.92x
DataCountMedium 34 37 +8.8% 0.92x
MapReduceAnyCollectionShort 2009 2173 +8.2% 0.92x
ArrayPlusEqualThreeElements 1669 1802 +8.0% 0.93x (?)
FlattenListFlatMap 6378 6875 +7.8% 0.93x (?)
MapReduceShort 1989 2141 +7.6% 0.93x
Improvement
Sim2DArray 398 311 -21.9% 1.28x
ReversedArray2 200 171 -14.5% 1.17x
RangeIterationSigned 200 171 -14.5% 1.17x
FatCompactMap 1404 1214 -13.5% 1.16x
MapReduceLazyCollectionShort 34 31 -8.8% 1.10x
DataCountSmall 37 34 -8.1% 1.09x
FrequenciesUsingReduce 4587 4217 -8.1% 1.09x

Code size: -O

TEST OLD NEW DELTA RATIO
Regression
AngryPhonebook.o 1035 3488 +237.0% 0.30x
SortStrings.o 27936 89398 +220.0% 0.31x
TwoSum.o 5466 13122 +140.1% 0.42x
SuperChars.o 1124 2567 +128.4% 0.44x
Chars.o 1475 2660 +80.3% 0.55x
DictTest.o 19163 34299 +79.0% 0.56x
StringEnum.o 11930 18760 +57.3% 0.64x
CString.o 8466 10426 +23.2% 0.81x
Phonebook.o 11660 14324 +22.8% 0.81x
Histogram.o 4171 4979 +19.4% 0.84x
COWArrayGuaranteedParameterOverhead.o 1175 1399 +19.1% 0.84x
Ackermann.o 1794 2106 +17.4% 0.85x
NSDictionaryCastToSwift.o 1625 1833 +12.8% 0.89x
ArrayLiteral.o 3085 3445 +11.7% 0.90x
Hash.o 39586 43470 +9.8% 0.91x
StringWalk.o 42919 46167 +7.6% 0.93x
FloatingPointPrinting.o 5895 6327 +7.3% 0.93x
RandomShuffle.o 3381 3621 +7.1% 0.93x
RGBHistogram.o 27642 29522 +6.8% 0.94x
ExistentialPerformance.o 68997 73581 +6.6% 0.94x
ObjectiveCBridgingStubs.o 18752 19968 +6.5% 0.94x
LazyFilter.o 9449 10041 +6.3% 0.94x
Array2D.o 4232 4496 +6.2% 0.94x
ChainedFilterMap.o 3117 3309 +6.2% 0.94x
DictionaryLiteral.o 1360 1440 +5.9% 0.94x
FlattenList.o 6312 6680 +5.8% 0.94x
TestsUtils.o 22275 23523 +5.6% 0.95x
InsertCharacter.o 5176 5464 +5.6% 0.95x
StringBuilder.o 7602 8018 +5.5% 0.95x
RandomValues.o 3808 4016 +5.5% 0.95x
RC4.o 4657 4905 +5.3% 0.95x
DictionaryBridge.o 3332 3508 +5.3% 0.95x
ArrayOfGenericRef.o 14244 14988 +5.2% 0.95x
OpenClose.o 3111 3271 +5.1% 0.95x
DataBenchmarks.o 56340 59236 +5.1% 0.95x
DictionaryGroup.o 16706 17551 +5.1% 0.95x
UTF8Decode.o 13002 13634 +4.9% 0.95x
Exclusivity.o 4443 4651 +4.7% 0.96x
PopFront.o 5155 5395 +4.7% 0.96x
DictOfArraysToArrayOfDicts.o 30820 32220 +4.5% 0.96x
StackPromo.o 2295 2399 +4.5% 0.96x
StringEdits.o 14327 14959 +4.4% 0.96x
Suffix.o 25417 26537 +4.4% 0.96x
Substring.o 18842 19658 +4.3% 0.96x
ObjectiveCBridging.o 43176 44998 +4.2% 0.96x
StringTests.o 8036 8372 +4.2% 0.96x
Prefix.o 23737 24729 +4.2% 0.96x
MapReduce.o 32824 34184 +4.1% 0.96x
ProtocolDispatch.o 781 813 +4.1% 0.96x
ReversedCollections.o 11163 11603 +3.9% 0.96x
RangeIteration.o 1626 1690 +3.9% 0.96x
Join.o 2240 2328 +3.9% 0.96x
PopFrontGeneric.o 4686 4870 +3.9% 0.96x
PrefixWhile.o 23070 23974 +3.9% 0.96x
StrToInt.o 4938 5130 +3.9% 0.96x
Combos.o 9901 10285 +3.9% 0.96x
DictionaryBridgeToObjC.o 6069 6301 +3.8% 0.96x
DropWhile.o 22676 23540 +3.8% 0.96x
ObserverForwarderStruct.o 3594 3730 +3.8% 0.96x
RangeAssignment.o 4882 5066 +3.8% 0.96x
ClassArrayGetter.o 5105 5297 +3.8% 0.96x
PointerArithmetics.o 1711 1775 +3.7% 0.96x
ObserverClosure.o 3279 3399 +3.7% 0.96x
CharacterLiteralsLarge.o 883 915 +3.6% 0.97x
SequenceAlgos.o 21475 22251 +3.6% 0.97x
Walsh.o 9090 9418 +3.6% 0.97x
ObjectiveCNoBridgingStubs.o 8181 8469 +3.5% 0.97x
RemoveWhere.o 27351 28311 +3.5% 0.97x
DropLast.o 24683 25539 +3.5% 0.97x
CaptureProp.o 925 957 +3.5% 0.97x
MonteCarloE.o 3266 3378 +3.4% 0.97x
DropFirst.o 24276 25108 +3.4% 0.97x
StringMatch.o 4445 4597 +3.4% 0.97x
ObserverPartiallyAppliedMethod.o 3567 3687 +3.4% 0.97x
ArrayAppend.o 39192 40472 +3.3% 0.97x
ObjectAllocation.o 4091 4219 +3.1% 0.97x
ArraySetElement.o 1031 1063 +3.1% 0.97x
RomanNumbers.o 5935 6119 +3.1% 0.97x
SortIntPyramids.o 12597 12981 +3.0% 0.97x
SevenBoom.o 1584 1632 +3.0% 0.97x
DoubleWidthDivision.o 544 560 +2.9% 0.97x
StringComparison.o 37860 38972 +2.9% 0.97x
NSStringConversion.o 1097 1129 +2.9% 0.97x
BinaryFloatingPointProperties.o 7564 7780 +2.9% 0.97x
SetTests.o 64829 66677 +2.9% 0.97x
ReduceInto.o 19258 19802 +2.8% 0.97x
ErrorHandling.o 3027 3107 +2.6% 0.97x
ArraySubscript.o 3954 4058 +2.6% 0.97x
ProtocolDispatch2.o 1840 1888 +2.6% 0.97x
ObserverUnappliedMethod.o 5266 5402 +2.6% 0.97x
LinkedList.o 1894 1942 +2.5% 0.98x
Radix2CooleyTukey.o 5070 5198 +2.5% 0.98x
Sim2DArray.o 1278 1310 +2.5% 0.98x
NSError.o 1279 1311 +2.5% 0.98x
RangeReplaceableCollectionPlusDefault.o 6083 6235 +2.5% 0.98x
NopDeinit.o 5151 5279 +2.5% 0.98x
CSVParsing.o 32721 33521 +2.4% 0.98x
Prims.o 42865 43905 +2.4% 0.98x
PrimsSplit.o 42917 43957 +2.4% 0.98x
CharacterLiteralsSmall.o 1325 1357 +2.4% 0.98x
RecursiveOwnedParameter.o 1382 1414 +2.3% 0.98x
ArrayOfRef.o 11802 12074 +2.3% 0.98x
WordCount.o 45460 46492 +2.3% 0.98x
DictionaryCopy.o 8512 8704 +2.3% 0.98x
NibbleSort.o 16220 16564 +2.1% 0.98x
SortLettersInPlace.o 8708 8892 +2.1% 0.98x
MonteCarloPi.o 1545 1577 +2.1% 0.98x
Fibonacci.o 1554 1586 +2.1% 0.98x
DriverUtils.o 148695 151711 +2.0% 0.98x
Queue.o 14291 14579 +2.0% 0.98x
ByteSwap.o 1594 1626 +2.0% 0.98x
Hanoi.o 3601 3673 +2.0% 0.98x
ArrayInClass.o 1613 1645 +2.0% 0.98x
StringInterpolation.o 7163 7291 +1.8% 0.98x
IterateData.o 1797 1829 +1.8% 0.98x
DeadArray.o 1802 1834 +1.8% 0.98x
BitCount.o 1818 1850 +1.8% 0.98x
XorLoop.o 1921 1953 +1.7% 0.98x
StaticArray.o 14039 14263 +1.6% 0.98x
Memset.o 2026 2058 +1.6% 0.98x
OpaqueConsumingUsers.o 2062 2094 +1.6% 0.98x
DictionarySubscriptDefault.o 28967 29407 +1.5% 0.99x
DictionaryKeysContains.o 11707 11883 +1.5% 0.99x
StrComplexWalk.o 3361 3409 +1.4% 0.99x
SortLargeExistentials.o 20630 20910 +1.4% 0.99x
ArrayOfPOD.o 2359 2391 +1.4% 0.99x
DictionarySwap.o 27803 28158 +1.3% 0.99x
Calculator.o 2546 2578 +1.3% 0.99x
CountAlgo.o 14884 15060 +1.2% 0.99x
ArrayOfGenericPOD.o 2770 2802 +1.2% 0.99x
AnyHashableWithAClass.o 2965 2997 +1.1% 0.99x
COWTree.o 13436 13580 +1.1% 0.99x
Improvement
DictionaryOfAnyHashableStrings.o 10877 10397 -4.4% 1.05x

Performance: -Osize

TEST OLD NEW DELTA RATIO
Regression
StringEnumRawValueInitialization 902 17713 +1863.7% 0.05x
ArrayLiteral 220 1484 +574.5% 0.15x
MapReduceLazyCollectionShort 41 85 +107.3% 0.48x
DataCreateSmallArray 27617 44118 +59.7% 0.63x
DataCreateMediumArray 3086 4716 +52.8% 0.65x
COWArrayGuaranteedParameterOverhead 11250 15418 +37.0% 0.73x
DropFirstAnySeqCntRange 15906 19748 +24.2% 0.81x
DropFirstAnySeqCntRangeLazy 15889 19547 +23.0% 0.81x
DropLastAnySeqCntRangeLazy 5295 6513 +23.0% 0.81x
PrefixAnySeqCntRange 15883 19536 +23.0% 0.81x
PrefixAnySeqCntRangeLazy 15886 19520 +22.9% 0.81x
DropLastAnySeqCntRange 5295 6487 +22.5% 0.82x
SuffixAnySeqCntRangeLazy 5295 6477 +22.3% 0.82x
SuffixAnySeqCntRange 5298 6476 +22.2% 0.82x
ObjectiveCBridgeFromNSDictionaryAnyObject 108967 131307 +20.5% 0.83x
PrefixAnySeqCRangeIterLazy 16989 20373 +19.9% 0.83x
PrefixAnySeqCRangeIter 17022 20386 +19.8% 0.83x
FlattenListFlatMap 44677 52916 +18.4% 0.84x
DropWhileAnySeqCRangeIter 18062 21207 +17.4% 0.85x
DropFirstAnySeqCRangeIterLazy 21609 25220 +16.7% 0.86x
DropFirstAnySeqCRangeIter 21606 25201 +16.6% 0.86x
DictionaryLiteral 3233 3583 +10.8% 0.90x
DropWhileAnySeqCntRange 187 205 +9.6% 0.91x
ArrayAppendAscii 2862 3126 +9.2% 0.92x (?)
SuffixCountableRange 11 12 +9.1% 0.92x
Improvement
Sim2DArray 587 405 -31.0% 1.45x
CountAlgoString 4117 3578 -13.1% 1.15x
DropWhileAnySeqCntRangeLazy 282 246 -12.8% 1.15x
FrequenciesUsingReduce 4804 4241 -11.7% 1.13x
DropFirstAnyCollection 183 165 -9.8% 1.11x
PrefixWhileAnyCollectionLazy 176 159 -9.7% 1.11x
PrefixWhileAnySeqCntRangeLazy 176 159 -9.7% 1.11x
SuffixCountableRangeLazy 12 11 -8.3% 1.09x
ReversedDictionary2 342 315 -7.9% 1.09x

Code size: -Osize

TEST OLD NEW DELTA RATIO
Regression
AngryPhonebook.o 1144 3769 +229.5% 0.30x
SortStrings.o 28887 89949 +211.4% 0.32x
TwoSum.o 5277 13357 +153.1% 0.40x
SuperChars.o 1246 2850 +128.7% 0.44x
DictTest.o 17950 33550 +86.9% 0.54x
Chars.o 1613 2933 +81.8% 0.55x
StringEnum.o 12205 19027 +55.9% 0.64x
COWArrayGuaranteedParameterOverhead.o 1387 1811 +30.6% 0.77x
Ackermann.o 1909 2413 +26.4% 0.79x
CString.o 8330 10338 +24.1% 0.81x
Phonebook.o 12132 14940 +23.1% 0.81x
Histogram.o 4000 4904 +22.6% 0.82x
DoubleWidthDivision.o 625 733 +17.3% 0.85x
ArrayLiteral.o 2936 3417 +16.4% 0.86x
NSDictionaryCastToSwift.o 1658 1926 +16.2% 0.86x
RangeIteration.o 1722 1997 +16.0% 0.86x
PointerArithmetics.o 1816 2091 +15.1% 0.87x
DictionaryLiteral.o 1509 1733 +14.8% 0.87x
StackPromo.o 2325 2669 +14.8% 0.87x
RC4.o 3785 4321 +14.2% 0.88x
ByteSwap.o 1634 1862 +14.0% 0.88x
ProtocolDispatch.o 862 970 +12.5% 0.89x
Hash.o 21095 23671 +12.2% 0.89x
CharacterLiteralsLarge.o 948 1056 +11.4% 0.90x
OpenClose.o 3504 3891 +11.0% 0.90x
ArraySetElement.o 1167 1295 +11.0% 0.90x
ChainedFilterMap.o 3156 3492 +10.6% 0.90x
CaptureProp.o 1093 1209 +10.6% 0.90x
RandomShuffle.o 3419 3763 +10.1% 0.91x
RGBHistogram.o 27533 30173 +9.6% 0.91x
Exclusivity.o 4308 4719 +9.5% 0.91x
Walsh.o 6082 6650 +9.3% 0.91x
Sim2DArray.o 1450 1578 +8.8% 0.92x
MonteCarloPi.o 1530 1662 +8.6% 0.92x
NSStringConversion.o 1274 1382 +8.5% 0.92x
RandomValues.o 3481 3772 +8.4% 0.92x
BitCount.o 1586 1718 +8.3% 0.92x
Fibonacci.o 1594 1726 +8.3% 0.92x
RecursiveOwnedParameter.o 1313 1421 +8.2% 0.92x
LazyFilter.o 8761 9473 +8.1% 0.92x
TestsUtils.o 18707 20192 +7.9% 0.93x
PopFront.o 4966 5350 +7.7% 0.93x
CharacterLiteralsSmall.o 1428 1536 +7.6% 0.93x
SevenBoom.o 1768 1900 +7.5% 0.93x
RomanNumbers.o 6662 7158 +7.4% 0.93x
SequenceAlgos.o 23148 24868 +7.4% 0.93x
DictionaryBridge.o 3452 3704 +7.3% 0.93x
DeadArray.o 1842 1974 +7.2% 0.93x
Array2D.o 4379 4691 +7.1% 0.93x
DictionaryBridgeToObjC.o 5901 6317 +7.0% 0.93x
XorLoop.o 1890 2022 +7.0% 0.93x
LinkedList.o 1905 2037 +6.9% 0.94x
NSError.o 1663 1775 +6.7% 0.94x
Join.o 2501 2669 +6.7% 0.94x
Memset.o 1940 2068 +6.6% 0.94x
ArrayInClass.o 1840 1952 +6.1% 0.94x
InsertCharacter.o 4815 5106 +6.0% 0.94x
MonteCarloE.o 3642 3858 +5.9% 0.94x
FloatingPointPrinting.o 5184 5491 +5.9% 0.94x
RangeReplaceableCollectionPlusDefault.o 5520 5840 +5.8% 0.95x
Radix2CooleyTukey.o 4756 5031 +5.8% 0.95x
ProtocolDispatch2.o 1884 1992 +5.7% 0.95x
IterateData.o 1989 2101 +5.6% 0.95x
ObjectiveCBridging.o 41127 43417 +5.6% 0.95x
PopFrontGeneric.o 4775 5039 +5.5% 0.95x
ObjectAllocation.o 3982 4202 +5.5% 0.95x
FlattenList.o 6696 7064 +5.5% 0.95x
Integrate.o 2454 2586 +5.4% 0.95x
StringMatch.o 4873 5129 +5.3% 0.95x
Calculator.o 2522 2654 +5.2% 0.95x
ObserverClosure.o 3573 3757 +5.1% 0.95x
RangeAssignment.o 5053 5309 +5.1% 0.95x
StringEdits.o 13342 14014 +5.0% 0.95x
DictOfArraysToArrayOfDicts.o 31412 32972 +5.0% 0.95x
ErrorHandling.o 3062 3214 +5.0% 0.95x
UTF8Decode.o 12357 12965 +4.9% 0.95x
ArraySubscript.o 3866 4050 +4.8% 0.95x
DictionaryKeysContains.o 11459 12003 +4.7% 0.95x
ArrayAppend.o 32412 33940 +4.7% 0.95x
ArrayOfPOD.o 2735 2863 +4.7% 0.96x
ClassArrayGetter.o 5169 5401 +4.5% 0.96x
ObserverPartiallyAppliedMethod.o 3927 4103 +4.5% 0.96x
OpaqueConsumingUsers.o 2113 2205 +4.4% 0.96x
DictionaryGroup.o 15799 16479 +4.3% 0.96x
StringTests.o 7668 7991 +4.2% 0.96x
Hanoi.o 3810 3970 +4.2% 0.96x
ObserverForwarderStruct.o 3838 3998 +4.2% 0.96x
SortIntPyramids.o 12321 12833 +4.2% 0.96x
Combos.o 10245 10669 +4.1% 0.96x
StringBuilder.o 7158 7454 +4.1% 0.96x
ReduceInto.o 14360 14936 +4.0% 0.96x
ReversedCollections.o 11612 12076 +4.0% 0.96x
DictionaryCopy.o 7865 8177 +4.0% 0.96x
Prims.o 38933 40469 +3.9% 0.96x
PrimsSplit.o 38985 40521 +3.9% 0.96x
ArrayOfGenericRef.o 13404 13916 +3.8% 0.96x
SortLettersInPlace.o 8779 9099 +3.6% 0.96x
StrComplexWalk.o 3282 3398 +3.5% 0.97x
ArrayOfGenericPOD.o 3002 3106 +3.5% 0.97x
NopDeinit.o 5564 5756 +3.5% 0.97x
MapReduce.o 26448 27352 +3.4% 0.97x
ObjectiveCBridgingStubs.o 17944 18552 +3.4% 0.97x
AnyHashableWithAClass.o 3181 3285 +3.3% 0.97x
CountAlgo.o 14668 15140 +3.2% 0.97x
RemoveWhere.o 25137 25905 +3.1% 0.97x
Suffix.o 24641 25393 +3.1% 0.97x
WordCount.o 41708 42980 +3.0% 0.97x
CSVParsing.o 33089 34089 +3.0% 0.97x
ObserverUnappliedMethod.o 5571 5731 +2.9% 0.97x
DataBenchmarks.o 51029 52469 +2.8% 0.97x
BinaryFloatingPointProperties.o 7417 7625 +2.8% 0.97x
DropWhile.o 21700 22308 +2.8% 0.97x
PrefixWhile.o 22766 23382 +2.7% 0.97x
StrToInt.o 5063 5199 +2.7% 0.97x
DropFirst.o 22420 23012 +2.6% 0.97x
Queue.o 13123 13467 +2.6% 0.97x
StaticArray.o 13019 13355 +2.6% 0.97x
HashQuadratic.o 5080 5208 +2.5% 0.98x
DropLast.o 24243 24827 +2.4% 0.98x
Substring.o 17154 17562 +2.4% 0.98x
ArrayOfRef.o 12514 12810 +2.4% 0.98x
Prefix.o 22537 23065 +2.3% 0.98x
DictionarySubscriptDefault.o 27135 27743 +2.2% 0.98x
StringRemoveDupes.o 8201 8377 +2.1% 0.98x
NibbleSort.o 18596 18940 +1.8% 0.98x
StringWalk.o 37400 38064 +1.8% 0.98x
SetTests.o 58141 59117 +1.7% 0.98x
DictionaryCompactMapValues.o 19326 19638 +1.6% 0.98x
StringInterpolation.o 6484 6588 +1.6% 0.98x
DictionarySwap.o 27107 27531 +1.6% 0.98x
COWTree.o 13594 13802 +1.5% 0.98x
DictTest4.o 20791 21087 +1.4% 0.99x
DriverUtils.o 134615 136495 +1.4% 0.99x
PolymorphicCalls.o 7465 7569 +1.4% 0.99x
StringComparison.o 33652 34116 +1.4% 0.99x
TypeFlood.o 8641 8753 +1.3% 0.99x
DictTest4Legacy.o 23337 23633 +1.3% 0.99x
ObjectiveCNoBridgingStubs.o 8087 8175 +1.1% 0.99x
DictionaryRemove.o 15687 15855 +1.1% 0.99x
Improvement
DictionaryOfAnyHashableStrings.o 10645 10317 -3.1% 1.03x
SortLargeExistentials.o 21238 20702 -2.5% 1.03x

Performance: -Onone

TEST OLD NEW DELTA RATIO
Regression
ArrayAppendLazyMap 161573 215428 +33.3% 0.75x
DropLastAnySeqCntRange 5535 7109 +28.4% 0.78x
DropLastAnySeqCntRangeLazy 5522 7091 +28.4% 0.78x
PrefixAnySeqCntRangeLazy 16510 21195 +28.4% 0.78x
SuffixAnySeqCntRangeLazy 5513 7074 +28.3% 0.78x
ObjectiveCBridgeFromNSDictionaryAnyObject 108440 138888 +28.1% 0.78x
SuffixAnyCollection 5538 7081 +27.9% 0.78x
SuffixAnySeqCntRange 5529 7067 +27.8% 0.78x
DropLastAnyCollection 5542 7078 +27.7% 0.78x
PrefixWhileAnySeqCntRangeLazy 19406 24783 +27.7% 0.78x
DropFirstAnySeqCntRangeLazy 16606 21178 +27.5% 0.78x
PrefixAnyCollection 16526 21070 +27.5% 0.78x
DropFirstAnySeqCntRange 16613 21170 +27.4% 0.78x
PrefixWhileAnySeqCRangeIterLazy 19376 24615 +27.0% 0.79x
DropFirstAnyCollection 16613 21057 +26.8% 0.79x
PrefixWhileCountableRangeLazy 19463 24626 +26.5% 0.79x
PrefixWhileAnyCollectionLazy 19514 24529 +25.7% 0.80x
Histogram 5770 7217 +25.1% 0.80x
PrefixAnySeqCRangeIterLazy 18039 22458 +24.5% 0.80x
DropWhileAnySeqCntRange 21478 26190 +21.9% 0.82x
DropFirstAnySeqCRangeIter 22514 27021 +20.0% 0.83x
DropFirstAnySeqCRangeIterLazy 22593 27064 +19.8% 0.83x
DictionaryGroup 4567 5351 +17.2% 0.85x
SubstringEquatable 4628 5390 +16.5% 0.86x
CharIndexing_tweet_unicodeScalars_Backwards 748646 862460 +15.2% 0.87x
PrefixWhileAnySeqCntRange 31220 35960 +15.2% 0.87x
SuffixAnySeqCRangeIterLazy 33276 38227 +14.9% 0.87x
SuffixAnySeqCRangeIter 33229 38135 +14.8% 0.87x
PrefixWhileAnyCollection 31485 36001 +14.3% 0.87x
DropLastAnySeqCRangeIterLazy 39630 44140 +11.4% 0.90x
DropLastAnySeqCRangeIter 39754 44225 +11.2% 0.90x
PrefixArrayLazy 34923 38474 +10.2% 0.91x
ArrayOfPOD 781 856 +9.6% 0.91x (?)
PrefixWhileAnySeqCRangeIter 35120 38352 +9.2% 0.92x
Improvement
CountAlgoString 6372 5217 -18.1% 1.22x
Memset 12875 11730 -8.9% 1.10x
XorLoop 8019 7333 -8.6% 1.09x

Code size: -swiftlibs

TEST OLD NEW DELTA RATIO
Regression
libswiftSwiftPrivateLibcExtras.dylib 20480 24576 +20.0% 0.83x
libswiftSwiftReflectionTest.dylib 49152 53248 +8.3% 0.92x
libswiftFoundation.dylib 1593344 1679360 +5.4% 0.95x
libswiftCloudKit.dylib 94208 98304 +4.3% 0.96x
libswiftSwiftOnoneSupport.dylib 163840 167936 +2.5% 0.98x
libswiftsimd.dylib 266240 270336 +1.5% 0.98x
libswiftStdlibUnittest.dylib 372736 376832 +1.1% 0.99x
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 16 GB
--------------

@moiseev
Copy link
Contributor Author

moiseev commented Nov 10, 2018

That is clearly a bad idea. Closing.

@moiseev moiseev closed this Nov 10, 2018
@moiseev moiseev deleted the bridge-uninline branch November 10, 2018 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants