[Sema] [CSDiag] Fix incorrect diagnostic when using keypath with tuples #20495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test EDIT: Just realised only people with commit access can invoke swift-ci 😅 |
Azoy
reviewed
Nov 10, 2018
|
@theblixguy once you fix this small newline nit I mentioned, I'll run the CI for you. |
Done! @xedin |
|
@swift-ci please smoke test |
|
@xedin Seems like it can be merged now 🎉 |
|
@theblixguy Thank you! |
theblixguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where an incorrect diagnostic would be emitted when using key path with tuples.
Resolves SR-9213.