[Keypaths] Use mangled names to reference types and witness tables in metadata #20499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
1 similar comment
|
@swift-ci please smoke test Linux |
DougGregor
force-pushed
the
keypath-metadata-mangling
branch
from
430f4a8 to
e99d937
Compare
…ssors. Switch key path metadata over to mangled names for each of the places it refers to either a type metadata accessor or a witness table accessor. For now, the mangled name is a symbolic reference to the existing accessors. Part of rdar://problem/38038799.
When a type in keypath metadata is non-dependent, use a mangled type name rather than a symbolic reference to an accessor function. Part of rdar://problem/38038799.
DougGregor
force-pushed
the
keypath-metadata-mangling
branch
from
e99d937 to
7b8bbcd
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In keypath metadata, use mangled names to reference type metadata and witness tables. There are three cases:
This is the main ABI part of rdar://problem/38038799. We'd still like to use real mangling here instead of fake ones with accessors.