[NFC] Rename @sil_stored to @_hasStorage #20512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlanhaskins
force-pushed
the
storage-wars
branch
from
2a05acb to
32b31e7
Compare
|
Build failed |
harlanhaskins
force-pushed
the
storage-wars
branch
from
32b31e7 to
8ae2621
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
jrose-apple
approved these changes
Nov 12, 2018
lib/Sema/TypeCheckAttr.cpp
Outdated
| @@ -846,7 +846,7 @@ class AttributeChecker : public AttributeVisitor<AttributeChecker> { | |||
| IGNORED_ATTR(Semantics) | |||
| IGNORED_ATTR(ShowInInterface) | |||
| IGNORED_ATTR(SILGenName) | |||
| IGNORED_ATTR(SILStored) | |||
| IGNORED_ATTR(HasStorage) | |||
There was a problem hiding this comment.
Nitpick: This list is alphabetical.
harlanhaskins
force-pushed
the
storage-wars
branch
from
8ae2621 to
66a61c5
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Let's try this again. @swift-ci please smoke test |
|
I think the CI issues have shaken out by now. @swift-ci please smoke test |
rjmccall
approved these changes
Nov 13, 2018
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split off from #20250. Because we're going to start using this attribute outside of SIL (in
.swiftinterfacefiles), rename it.