Skip to content

Tolerate scalars when opening a non-opaque existential l-value component #20515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2018
Merged

Tolerate scalars when opening a non-opaque existential l-value component #20515

merged 1 commit into from
Nov 13, 2018

Conversation

rjmccall
Copy link
Contributor

rdar://45956703

@rjmccall
Copy link
Contributor Author

@swift-ci Please test.

@rjmccall rjmccall requested a review from jckarter November 12, 2018 20:44
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a4ea4d1

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a4ea4d1

@rjmccall
Copy link
Contributor Author

@swift-ci Please clean test.

jckarter
jckarter approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a4ea4d1

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a4ea4d1

@rjmccall
Copy link
Contributor Author

@swift-ci Please test.

@rjmccall
Copy link
Contributor Author

CI seems to have recovered.

@rjmccall rjmccall merged commit c34779c into swiftlang:master Nov 13, 2018
@rjmccall rjmccall deleted the scalar-opened-existential-metatypes branch November 13, 2018 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter jckarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjmccall @swift-ci @jckarter