Skip to content

Make sure the code completion takes both private imports and testable #20525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 14, 2018
Merged

Make sure the code completion takes both private imports and testable #20525

merged 5 commits into from
Nov 14, 2018

Conversation

aschwaighofer
Copy link
Contributor

imports into account separately.

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 2ac6cda

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2ac6cda

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 2ac6cda

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2ac6cda

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ca68632

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ca68632

benlangmuir
benlangmuir requested changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@benlangmuir benlangmuir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case in test/IDE/complete_cache.swift. There's one for @testable that you could base it on. Otherwise, LGTM!

include/swift/AST/Module.h Outdated
@@ -990,7 +990,18 @@ class SourceFile final : public FileUnit {

void addImports(ArrayRef<ImportedModuleDesc> IM);

bool hasTestableOrPrivateImport(AccessLevel accessLevel, const ValueDecl *ofDecl) const;
enum ImportQueryKind {
/// Return the resuls for testable or private imports.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: missing "t" in results.

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please smoke test

@aschwaighofer aschwaighofer merged commit 9debb38 into swiftlang:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlangmuir benlangmuir benlangmuir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aschwaighofer @swift-ci @benlangmuir