[ParseSIL] Fix SILParser::parseSILIdentifierSwitch
#20546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
changed the title
SILParser::parseSILIdentifierSwitchSILParser::parseSILIdentifierSwitch
|
@swift-ci please smoke test |
|
This LGTM. That being said, I do think the commit comment can be improved. Can you mention in the commit comment that Result has the type of one of the template parameters and without this patch we are requiring T to be a ValueOwnershipKind (or convertible to that), which sort of defeats the point of having a templated argument. |
|
I can update the comment either by making a new squash commit message or overwrite the commit and retrigger CI. Which do you prefer? |
|
Given that the macOS test failed, I would just overwrite and retrigger the CI. |
…meter. In `parseSILIdentifierSwitch`, `Result` has the type of one of the template parameters. Without this patch we are requiring `T` to be a `ValueOwnershipKind` (or convertible to that), which makes the function not usable on other result types and defeats the point of having a templated argument.
|
Done. |
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
|
Nice commit message! = ). Thanks for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template
SILParser::parseSILIdentifierSwitchshould not useValueOwnershipKindin its implementation.