Skip to content

Add frontend option -no-serialize-debugging-options #20555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jrose-apple
Copy link
Contributor

By default, the frontend tries to figure out if the built module is likely to be distributed in some way, and uses that to decide whether to include options that help with debugging (such as local search paths). There's long been a -serialize-debugging-options that forces those options to be included even when it looks like a framework is being built, but the opposite has been absent until now.

Note that both of these options are still frontend options, not driver options, which means they could still change in the future. (I'd really like to get to a point where debugging doesn't need to sniff these options out from the module this way, but there are some complications we'd need to work out. Swift 1 expediency coming back to cause trouble again.)

rdar://problem/37954803

By default, the frontend tries to figure out if the built module is
likely to be distributed in some way, and uses that to decide whether
to include options that help with debugging (such as local search
paths). There's long been a -serialize-debugging-options that forces
those options to be included even when it looks like a framework is
being built, but the opposite has been absent until now.

Note that both of these options are still /frontend/ options, not
driver options, which means they could still change in the future.
(I'd really like to get to a point where debugging doesn't need to
sniff these options out from the module this way, but there are some
complications we'd need to work out. Swift 1 expediency coming back to
cause trouble again.)

rdar://problem/37954803
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

Copy link
Contributor

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good.

@jrose-apple jrose-apple merged commit 25c6c16 into swiftlang:master Nov 14, 2018
@jrose-apple jrose-apple deleted the no-serialize-debugging-options branch November 14, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants