Skip to content

Hide irreleveant command line options of lldb-moduleimport-test #20577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2018
Merged

Hide irreleveant command line options of lldb-moduleimport-test #20577

merged 1 commit into from
Nov 15, 2018

Conversation

adrian-prantl
Copy link
Contributor

No description provided.

@adrian-prantl
Copy link
Contributor Author

@swift-ci test and merge

@adrian-prantl
Copy link
Contributor Author

@swift-ci smoke test

jrose-apple
jrose-apple reviewed Nov 14, 2018
View reviewed changes
tools/lldb-moduleimport-test/lldb-moduleimport-test.cpp
llvm::cl::OneOrMore);
using namespace llvm::cl;
static OptionCategory Visible("Specific Options");
HideUnrelatedOptions({&Visible});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like HideUnrelatedOptions(None) will hide everything, and then the following options don't need to get a category.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know! But this way it also prints nicely in the --help output as

General options:
--version ...
Specific options:
--dump-module ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, do you happen to know what's up with the failure in https://ci.swift.org/job/swift-PR-osx/8961/ ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graydon's disabling the test in #20581 while he investigates.

@adrian-prantl
Copy link
Contributor Author

Oh. I didn't realize that that test failure was connected to this change! From the looks of it, module-cache-diagnostics.swift doesn't even run lldb-moduleimport-test — do you understand how they are connected?

@adrian-prantl
Copy link
Contributor Author

Oh I think I misread your comment: They aren't!

@adrian-prantl
Copy link
Contributor Author

@swift-ci test and merge

@swift-ci swift-ci merged commit 8fb8112 into swiftlang:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrian-prantl @jrose-apple @swift-ci