Skip to content

[GSB] NFC: Couple of minor cleanups #20594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Nov 15, 2018

  • getOrCreateRewriteTreeRoot can't fail (unless it fails to allocate memory)
  • mark equivClass2 as modified as per original comment

@xedin xedin force-pushed the minor-gsb-cleanups branch from 625dce7 to 9c186d9 Compare November 15, 2018 08:29
- getOrCreateRewriteTreeRoot can't fail (unless it fails to allocate memory)
- mark `equivClass2` as modified as per original comment
@xedin xedin force-pushed the minor-gsb-cleanups branch from 9c186d9 to a21990f Compare November 15, 2018 08:34
@xedin xedin requested a review from DougGregor November 15, 2018 08:35
@xedin
Copy link
Contributor Author

xedin commented Nov 15, 2018

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Nov 15, 2018

@swift-ci please test source compatibility

@xedin xedin merged commit 3ab5a73 into swiftlang:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants