[ABI] Use generic environment to handle mangled generic keypath types. #20640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the key-path pattern with a representation of the generic environment of the key-path, which includes the generic parameters and generic requirements of the environment.
Found by inspection.
Only use the metadata and context information during initial setup, not later on. NFC just yet.
A paste-o in GenericEnvironmentFlags meant we didn’t have well-formed metadata.
Always use mangled type names to represent type metadata in keypath patterns. For generic types, use the generic environment to pull substituted types from the instantiation arguments. Finishes the type metadata part of rdar://problem/38038799.
|
@swift-ci please smoke test and merge |
jckarter
approved these changes
Nov 16, 2018
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use mangled type names to represent type metadata in keypath patterns.
For generic types, use the generic environment to pull substituted types
from the instantiation arguments.
Finishes the type metadata part of rdar://problem/38038799.