-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[runtime] Register a hook for class name lookup from libobjc #20650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[runtime] Register a hook for class name lookup from libobjc #20650
Conversation
libobjc needs to look up classes by name. Some Swift classes, such as instantiated generics and their subclasses, are created only on demand. Now a by-name lookup from libobjc counts as a demand for those classes. rdar://problem/27808571
@slavapestov I only have tests for generic classes here; are there resilience cases that we can test now? |
@swift-ci please test |
@gparker42 Look at how test/Interpreter/objc_class_resilience.swift builds and links test/Inputs/resilient_classes.swift and test/Inputs/resilient_structs.swift as a dylib with resilience enabled. What you want to do is test two cases:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but more tests will always be good of course
@swift-ci please test |
Build failed |
Build failed |
…ng#20650) libobjc needs to look up classes by name. Some Swift classes, such as instantiated generics and their subclasses, are created only on demand. Now a by-name lookup from libobjc counts as a demand for those classes. rdar://problem/27808571
[5.0][runtime] Register a hook for class name lookup from libobjc (#20650)
…ng#20650) libobjc needs to look up classes by name. Some Swift classes, such as instantiated generics and their subclasses, are created only on demand. Now a by-name lookup from libobjc counts as a demand for those classes. rdar://problem/27808571
libobjc needs to look up classes by name. Some Swift classes, such as
instantiated generics and their subclasses, are created only on demand.
Now a by-name lookup from libobjc counts as a demand for those classes.
rdar://problem/27808571