Skip to content

Fix a bug with inlining self-conformances #20658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2018

Conversation

rjmccall
Copy link
Contributor

No description provided.

@rjmccall rjmccall force-pushed the substitute-self-conformance branch from 13fe7ec to cd2b558 Compare November 17, 2018 03:59
@rjmccall
Copy link
Contributor Author

@swift-ci Please smoke test.

@slavapestov
Copy link
Contributor

Thanks!

@rjmccall
Copy link
Contributor Author

You were right!

@slavapestov
Copy link
Contributor

@rjmccall I think this needs a test case though.

@rjmccall
Copy link
Contributor Author

rjmccall commented Nov 17, 2018

It's in #20629. There are no self-conformances that don't satisfy isObjCExistentialType() without that.

@rjmccall rjmccall merged commit abfe7f5 into swiftlang:master Nov 17, 2018
@rjmccall rjmccall deleted the substitute-self-conformance branch November 17, 2018 05:01
rjmccall added a commit to rjmccall/swift that referenced this pull request Nov 17, 2018
rjmccall added a commit that referenced this pull request Nov 17, 2018
rjmccall added a commit to rjmccall/swift that referenced this pull request Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants