Skip to content

[stdlib] Remove Strideable closed range operator #20665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2018
Merged

[stdlib] Remove Strideable closed range operator #20665

merged 2 commits into from
Dec 12, 2018

Conversation

benrimmington
Copy link
Contributor

This pull request removes the closed range operator on Strideable.
It was originally for CountableClosedRange, when that was a separate type.
The other countable range operators on Strideable were removed in #13342.

@benrimmington
Copy link
Contributor Author

Cc: @airspeedswift, @natecook1000

Should any of the removed documentation be transferred to the Comparable extension?

@airspeedswift
Copy link
Member

@swift-ci please test

@airspeedswift
Copy link
Member

@swift-ci please test source compatibility

@airspeedswift airspeedswift self-assigned this Nov 20, 2018
@benrimmington
Copy link
Contributor Author

There were five failures in the Source Compatibility Suite.

  FAIL: Kitura, 4.0, f1c316, Swift Package
  FAIL: NetService, 4.2, 927eb1, Swift Package
  FAIL: SRP, 4.0, b16683, Swift Package
  FAIL: SwiftLint, 4.2, 60f98e, Swift Package
  FAIL: SwiftLint, 4.0, 60f98e, Swift Package

Each log contained "error: dependency graph is unresolvable; found these conflicting requirements"...

@benrimmington
Copy link
Contributor Author

The projects were XFAILed in swiftlang/swift-source-compat-suite@5d5f258

@benrimmington benrimmington force-pushed the remove-strideable-closed-range-operator branch from 3beaab1 to c599749 Compare November 27, 2018 13:00
@benrimmington
Copy link
Contributor Author

Rebased to resolve conflict.

@jrose-apple
Copy link
Contributor

Passerby testing

@swift-ci please test

@jrose-apple
Copy link
Contributor

@swift-ci Please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 3beaab19d8a2fc901f38b7291202bf4a384e1679

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 3beaab19d8a2fc901f38b7291202bf4a384e1679

@airspeedswift
Copy link
Member

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 2187022 into swiftlang:master Dec 12, 2018
@benrimmington benrimmington deleted the remove-strideable-closed-range-operator branch December 12, 2018 17:11
airspeedswift pushed a commit to airspeedswift/swift that referenced this pull request Dec 12, 2018
@swift-ci @airspeedswift
Remove Strideable closed range operator swiftlang#20665
ef3d89f
@airspeedswift airspeedswift mentioned this pull request Dec 12, 2018
Merged
airspeedswift added a commit that referenced this pull request Dec 12, 2018
@airspeedswift
Remove Strideable closed range operator #20665 (#21252)
5780f47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@airspeedswift airspeedswift

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benrimmington @airspeedswift @jrose-apple @swift-ci