Fix symbolicate linux fatal for streaming stacktraces 2 #20681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmilos
force-pushed
the
fix-symbolicate-linux-fatal-for-streaming-stacktraces-2
branch
from
94a355b to
eb06d8e
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
gmilos
force-pushed
the
fix-symbolicate-linux-fatal-for-streaming-stacktraces-2
branch
from
07bdb2d to
b0022eb
Compare
|
@swift-ci please smoke test |
gmilos
force-pushed
the
fix-symbolicate-linux-fatal-for-streaming-stacktraces-2
branch
from
b0022eb to
820d5f3
Compare
|
@swift-ci please smoke test |
alblue
deleted the
fix-symbolicate-linux-fatal-for-streaming-stacktraces-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symbolicate-linux-fataldoesn't handle series of stack-traces properly. Only the first one is symbolicated OK. More details:https://bugs.swift.org/browse/SR-7651
It turns out it was a simple setup issue, where File Addr vs Phys Addr (a.k.a.
text_section.GetFileAddress() - text_section.GetFileOffset()) were only properly considered on the first iteration.This is a reworked and updated version of: #16494