[CSDiagnostics] Add custom diagnostic for invalid @autoclosure forwarding #20693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
…ks for subscripts/members Currently logic in `matchCallArguments` could only detect argument being an @autoclosure parameter for normal calls and operators. This patch extends it to support subscripts and unresolved member calls.
…ding Suggest to add `()` (form a call) to correctly forward argument function originated from `@autoclosure` parameter to function parameter itself marked as `@autoclosure`.
xedin
force-pushed
the
forward-autoclosure-diagnostic
branch
from
d242f27 to
07e5d54
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggest to add
()(form a call) to correctly forward argument functionoriginated from
@autoclosureparameter to function parameter itselfmarked as
@autoclosure.