[5.0][stdlib] _StringObject: Use a full 8-bit discriminator on 32-bit platforms #20702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…forms We now have plenty of extra inhabitants in the variant enum, so we can get rid of the 7-bit hack. It’d also be possible now to increase small string capacity to a spacious 11 bytes; however this needs a full overhaul of the 32-bit representation, so it needs a little bit more time in the oven.
|
Note: This is an ABI-breaking change on 32-bit platforms. |
|
@swift-ci test |
|
As czar I am technically a branch manager; but I do not feel qualified to give positive approval for changes to the branch. czar is strictly a defensive role. |
|
That's fine! This can wait until @airspeedswift gets back -- I just wanted it up and ready. |
milseman
approved these changes
Nov 26, 2018
airspeedswift
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20561 gave us plenty of extra inhabitants in the variant enum, so we can get rid of the 7-bit hack.
It’d also be possible now to increase small string capacity to a spacious 11 bytes; however this needs a full overhaul of the 32-bit String representation, so it needs a little bit more time in the oven.
Cherry picked from #20643, reviewed by @milseman
rdar://problem/44232093