ClangImporter: make bridging header portable #20707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@jrose-apple - created a thread at https://forums.swift.org/t/clangimporter-including-files/19119 to deal with this, as I'm not sure if this is sufficient to just change to a |
compnerd
force-pushed
the
import-bridging-header
branch
from
db596f4 to
e1ec85e
Compare
|
@swift-ci please test |
jrose-apple
approved these changes
Jan 17, 2019
|
Build failed |
|
Build failed |
`#import` on Windows is problematic at as the default behaviour in C/C++ mode is to be an import of a type library (COM feature). This can be adjusted by always enabling Objective-C interop on Windows, but the runtime is not always built with ObjC interop. Unfortunately, always using `#include` breaks semantics on Apple where some places rely on the include-once semantics of `#import`. For now, control the inclusion technique to be based on whether ObjC interop is enabled or not.
compnerd
force-pushed
the
import-bridging-header
branch
from
e1ec85e to
052c89d
Compare
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
#importis confusing when used on Windows targets as it istreated as a type library import. Use
#includeinstead. This shouldhave no impact on other targets.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.