-
Notifications
You must be signed in to change notification settings - Fork 10.5k
stdlib: check for ARM/ARM64/AArch64 more thoroughly #20709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdlib: check for ARM/ARM64/AArch64 more thoroughly #20709
Conversation
@swift-ci please test |
@airspeedswift - seems like @futurejones would like to nominate this for the 4.2-branch. This impacts the swift standard library, but should only impact the non-Apple ARM/AArch64 build targets, and is simply enabling the same paths under different names, so I consider it a low risk change. |
We generally don't add enhancements like this on old release branches. We should focus new work on the master branch and the active release branches. Besides, why do we need CI for a branch that isn't changing anymore? |
In Swift 4.1 we saw 4.1, 4.1.1, 4.1.2 and 4.1.3 releases. There absolutely no reason why we can not see a similar pattern of releases for Swift 4.2. Also these changes have already been added to the master - #19462 |
We're not planning any more releases from the 4.2 branch. The current release branch is for Swift 5.0, and I think we should focus our energies on that branch. |
@bob-wilson as stated before - these changes have already been added in PR 19462 |
This puts the Swift Arm community in a position again to maintain parallel repos. We've tried to work with the core team about this over the years, and they've expressed interest in helping us stay on mainline. However, not being willing to work with us pushes us away again. Swift 5 has not been released, and it's not usable for any user in production settings, let alone on Arm64. Saying that we should accept the fact that Swift 4.2 doesn't work on Arm64, and never will, because we need to wait until some indeterminate point in the future (WWDC 2019?), when Swift 5 is released is pretty painful. If you look at the changes proposed, they are incredibly minor. Furthermore, master has diverged from this enough that this patch would not be able to be cherry-picked from master into this branch. |
@tkremenek / @rjmccall what are your thoughts on this one? It looks okay to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
thanks @rjmccall , will take this one then |
Thank you. |
Changes needed for successful builds of 4.2 for AArch64 on the Swift Community CI.
(cherry picked from #19462)
Resolves SR-NNNN.