port SwiftPrivatePthreadExtras to Windows #20719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
force-pushed
the
threading-extras
branch
4 times, most recently
from
f3e3c1a to
fe4fd9a
Compare
|
@swift-ci please test |
|
Build failed |
compnerd
force-pushed
the
threading-extras
branch
from
fe4fd9a to
15f21ec
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
This is in preparation to make the code here more target agnostic for porting to the Windows threading primitives. This is used pretty extensively in the tests, so disabling tests would lose a chunk of coverage.
These were not in use, and removing this from the signature makes it possible to re-use the exact signature on Windows more easily.
The attributes were not being used currently. Since this is a private interface, remove the parameter as it makes it easier to port to Windows.
…D_BARRIER_SERIAL_THREAD
This is needed to build the threading extras.
…reaing Port the block based thread constructor to Windows threading model, and rename it to `_stdlib_create_thread_block`.
Implement `_stdlib_pthread_join` in terms of windows threading. Additionally, rename it to `_stdlib_thread_join`.
This has been generalized enough to permit building on Windows with Windows threading primitives.
compnerd
force-pushed
the
threading-extras
branch
from
15f21ec to
0aec837
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
CC: @jrose-apple ... not sure of a good person to ask to take a look at this change, and I'm not sure if there is something Apple internal which might be impacted here. |
lorentey
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.