[stdlib] Unchecked subscript on UnsafeBufferPointer #20767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a use an unchecked subscript on UnsafeBufferPointer, which skips debugPrecondition checks (in case we're not inlined) as well as a force-unwrap check.
|
@swift-ci please test |
|
@airspeedswift This change is beneficial, and not taking it will cause merge-conflict headaches in the future when we cherry-pick better string comparison and normalization. |
|
@apple/swift5-branch-managers
This change is not critical for convergence, but should be incorporated in the eventual release and will be a critical part of future performance work that we will definitely want to cherry-pick (better string comparison). We can take this now, or wait for the later changes that build on this.
This is ABI-additive, hence no change to the checker test file. |
airspeedswift
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a use an unchecked subscript on UnsafeBufferPointer, which skips
debugPrecondition checks (in case we're not inlined) as well as a
force-unwrap check.
Cherry-pick of #20621