Fix a logic error in eraseUseOfValue. #2077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -208,6 +208,10 @@ void swift::eraseUsesOfValue(SILValue V) { | |||
| auto *User = UI->getUser(); | |||
| UI++; | |||
|
|
|||
| // User could be removed at this point. | |||
There was a problem hiding this comment.
Is this the right fix? If the User is removed are we guaranteed to have it be nulled out?
Why not use a SmallPointerSet?
There was a problem hiding this comment.
One possibility is to collect all the direct and transitive users of the SILValue and remove them one by one. But that may leave us with some dead, but not removed instructions.
|
@swift-ci Please test Linux |
|
@swift-ci Please test |
I failed to create a test case. And we hav existing tests in FSO that will exercise this. rdar://25559780
|
@swift-ci Please test |
MaxDesiatov
pushed a commit
that referenced
this pull request
Apr 19, 2021
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.