[CMake] Conditionalize generation of .swiftinterface files #20784
Conversation
|
Still need to fix the tests that expect the swiftinterface files to be there… |
SWIFT_ENABLE_PARSEABLE_MODULE_INTERFACES is the new setting. rdar://problem/44942414
jrose-apple
force-pushed
the
generated-nine-out-of-ten
branch
from
3b55b05 to
022fe5d
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
| "${CMAKE_COMMAND}" "-E" "remove" "-f" "${module_doc_file}" | ||
| COMMAND | ||
| "${CMAKE_COMMAND}" "-E" "remove" "-f" "${interface_file}" | ||
| "${CMAKE_COMMAND}" "-E" "remove" "-f" ${module_outputs} |
There was a problem hiding this comment.
If this works, that is great. I recently learnt that the multi-file variant of the commands was added in CMake 3.5 for some of them :/
There was a problem hiding this comment.
Oh, hm. It works on my machine™ but I'll go check before I merge.
There was a problem hiding this comment.
Looks like it was in 3.4 at least, and our current oldest supported version is 3.4.3.
| // RUN: %empty-directory(%t) | ||
| // RUN: for x in %platform-sdk-overlay-dir/*.swiftinterface; do [[ $(basename "$x") = Swift.swiftinterface || $(basename "$x") = simd.swiftinterface || $(basename "$x") = SwiftLang.swiftinterface ]] && continue; %target-swift-frontend "$x" -emit-module -o %t/$(basename "$x" .swiftinterface).swiftmodule -disable-objc-attr-requires-foundation-module -enable-resilience -Fsystem %sdk/System/Library/PrivateFrameworks/ -swift-version 4 -O || echo '%target-os:' $(basename "$x") >> %t/failures.txt; done | ||
| // RUN: diff <(grep '%target-os:' %s) <(sort -f %t/failures.txt) | ||
| // RUN: for x in %platform-sdk-overlay-dir/*.swiftinterface; do [[ $(basename "$x") = Swift.swiftinterface || $(basename "$x") = simd.swiftinterface || $(basename "$x") = SwiftLang.swiftinterface || $(basename "$x") = '*.swiftinterface' ]] && continue; %target-swift-frontend "$x" -emit-module -o %t/$(basename "$x" .swiftinterface).swiftmodule -disable-objc-attr-requires-foundation-module -enable-resilience -Fsystem %sdk/System/Library/PrivateFrameworks/ -swift-version 4 -O || echo '%target-os:' $(basename "$x") >> %t/failures.txt; done |
There was a problem hiding this comment.
Ugh, this really makes the test difficult to port on windows :-(.
There was a problem hiding this comment.
This test is kind of a mess anyway. I should probably just write a Python script. But I don't think I've made it worse of a mess than it already was.
|
Unrelated XCTest failure. @swift-ci Please test Linux |
SWIFT_ENABLE_PARSEABLE_MODULE_INTERFACES is the new setting.
rdar://problem/44942414