[5.0] stdlib: Make ArrayBufferProtocol.init inlinable to facilitate specialization #20800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecialization Change the attribute of init(copying:) from @usableFromInline to @inlinable to enable generic specialization. Resulting in a 2x speedup of array copying. This is not ABI affecting because both @usableFromInline and @inlinable cause emission of the symbol in the standard library dylib. This is a fix for a performance regression from a previously shipped swift and it is not a correctness fix. SR-9284 rdar://46277030
|
@swift-ci Please test |
|
Not critical for convergence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the attribute of init(copying:) from @usableFromInline to
@inlinable to enable generic specialization. Resulting in a 2x speedup
of array copying.
This is not ABI affecting because both @usableFromInline and @inlinable
cause emission of the symbol in the standard library dylib.
This is a fix for a performance regression from a previously shipped
swift and it is not a correctness fix.
SR-9284
rdar://46277030