Skip to content

[test] Update ClangImporter/enum-anon.swift for Clang improvements #20804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

jrose-apple
Copy link
Contributor

We previously weren't able to import something properly, but now it's working because of some change in Clang. Let's take it!

rdar://problem/46263312

We previously weren't able to import something properly, but now it's
working because of some change in Clang. Let's take it!

rdar://problem/46263312
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

Copy link
Contributor

@bob-wilson bob-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this change with the build I did yesterday and verified that the test passes.

@jrose-apple
Copy link
Contributor Author

12:58:32 
llvm-config: error: component libraries and shared library
12:58:32 
12:58:32 llvm-config: error: missing: /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master-next/buildbot_incremental/llvm-macosx-x86_64/lib/libLLVMTestingSupport.a
12:58:32 CMake Warning at cmake/Modules/CompilerRTUtils.cmake:246 (message):
12:58:32   llvm-config finding xray failed with status 1

Uh, hm. Well, that's unrelated to my change, but it's funny that it didn't happen when I built locally. Oh well.

@jrose-apple jrose-apple merged commit c14c5c9 into swiftlang:master-next Nov 27, 2018
@jrose-apple jrose-apple deleted the anon-issue branch November 27, 2018 19:16
bob-wilson pushed a commit that referenced this pull request Feb 9, 2019
…20804)

We previously weren't able to import something properly, but now it's
working because of some change in Clang. Let's take it!

rdar://problem/46263312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants