[5.0][GSB] When adding same-type requirements pick representative based ... #20810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… canonical order Instead of trying to order based on the "nested depth", let's always prefer canonical ordering of type parameters when it comes to picking representative equivalence class. Resolves: rdar://problem/45957015 (cherry picked from commit c725660)
(cherry picked from commit ab3d1f5)
Instead of using `std::sort`, transform source-ordered edge vector to reference `IntercomponentEdge *` instead of their indices in `intercomponentEdges` vector and use `llvm::array_pod_sort` to sort them. (cherry picked from commit 439784d)
|
@swift-ci please test |
AnnaZaks
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... on canonical order
Instead of trying to order based on the "nested depth", let's
always prefer canonical ordering of type parameters when it comes
to picking representative equivalence class.
Resolves: rdar://problem/45957015