Remove DebugTypeInfo::isImplicitlyIndirect() #20814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found the corresponding code in LLDB that depended on this hack and am now removing both. This makes it possible to share the same code path for top-level archetypes and member types. rdar://problem/45462765
|
@swift-ci test with apple/swift-lldb#1102 |
|
@swift-ci test |
dcci
approved these changes
Nov 28, 2018
|
test with apple/swift-lldb#1102 |
|
@bob-wilson This change is necessary to fix printing tuples of generic values in LLDB (see rdar://problem/45462765). It only affects debug info, not codegen, and thus has no ABI implications. |
|
test with apple/swift-lldb#1102 |
|
Thank you so much for ripping this out! |
|
This looks fine but unless it's really blocking something, let's wait until next week to merge it. |
bob-wilson
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the corresponding code in LLDB that depended on this hack and
am now removing both. This makes it possible to share the same code
path for top-level archetypes and member types.
rdar://problem/45462765