AST: Don't mangle weak/unowned as part of a property's type [5.0; ABI] #20818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LibraryEvolution.rst stipulates that adding or removing 'weak', 'unowned' and 'unowned(unsafe)' is a resilient change if the type is resilient. This means we should not mangle these attributes as part of the accessor declaration.
|
@swift-ci Please test |
slavapestov
changed the title
|
This looks like a small change/bug fix. Is this impacting the convergence? |
|
@AnnaZaks it does not impact convergence but it is an ABI change |
AnnaZaks
approved these changes
Nov 28, 2018
|
Merging this because is an isolated fix which has an ABI impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LibraryEvolution.rst stipulates that adding or removing 'weak',
'unowned' and 'unowned(unsafe)' is a resilient change if the type
is resilient. This means we should not mangle these attributes as
part of the accessor declaration.