[ownership] Ban ValueOwnershipKind::Any in preparation for eliminated ValueOwnershipKind::Trivial #20819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://46294760
…the one that takes the SILModule * the helper method instead of vis-a-versa. We already assume in the given static method that the module is a non-null pointer. So rather than us indirecting a ref to a pointer and then dereferencing the pointer, we instead use the ref in the module implementation and dereference the pointer. rdar://46294760
…s and owned for non-trivial values. This is in preparation for verifying that when ownership verification is enabled that only enums and trivial values can have any ownership. I am doing this in preparation for eliminating ValueOwnershipKind::Trivial. rdar://46294760
…anging Trivial to be Any. rdar://46294760
|
@swift-ci test |
|
@swift-ci source compatibility |
|
@swift-ci Test Source Compatibility |
|
@swift-ci Please Test Source Compatibility |
|
@swift-ci smoke benchmark |
|
(not expecting benchmark changes, just want to run the benchmarks) |
|
"and start debriding" What is debriding? |
Build comment file:No performance and code size changes |
Debridement is the removal of dead or damaged tissue to improve healing of the remaining healthy tissue. (The most intriguing form of debridement, of course, is maggot therapy.) While in general I'd be in favor of LMGTFY, searching about debridement comes with certain hazards... |
|
Talked with Andy. He is going to do post-commit review on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates our usage of ValueOwnershipKind::Any's old undef like semantics and temporarily bans ValueOwnershipKind::Any when ownership verification is enabled. This involves:
Changing SILUndef to produce owned ownership if it has a non-trivial type and trivial ownership if it has a trivial type. This involved storing in SILUndef said ValueOwnershipKind since we do not have access to a SILModule when computing the ValueOwnershipKind of a SILValue.
Adding an assert that bans ValueOwnershipKind::Any for /all/ values.
After this commit, I should be able to just do a sed-ish replace of all references to ValueOwnershipKind::Trivial to ValueOwnershipKind::Any and start debriding.
rdar://46294760