IRGen: Consider the superclass bound of archetypes in searchTypeMetadata #20827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to search the type metadata of superclass bounds to handle signatures like:
class K<T> {}
$@convention(witness_method: A2) <τ_0_0><τ_1_0 where τ_0_0 : K<τ_1_0>, τ_1_0 : C> (@in_guaranteed τ_0_0) -> ()
rdar://46173958
SR-9305
|
@swift-ci Please test |
rjmccall
reviewed
Nov 28, 2018
lib/IRGen/Fulfillment.cpp
Outdated
| @@ -124,6 +124,15 @@ bool FulfillmentMap::searchTypeMetadata(IRGenModule &IGM, CanType type, | |||
| source, MetadataPath(path), keys); | |||
| } | |||
|
|
|||
| // If the type is an archetype consider its super class bound. | |||
| if (isa<ArchetypeType>(type)) | |||
| if (metadataState == MetadataState::Complete) { | |||
There was a problem hiding this comment.
Maybe this should be the same condition as below, i.e. metadataState == MetadataState::Complete && keys.isInterestingType(type)) rather than checking specifically for ArchetypeType.
There was a problem hiding this comment.
I will lift the restriction. Is interestingType(type) is checked earlier.
… (checked earlier)
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please smoke test |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to search the type metadata of superclass bounds to handle signatures like:
class K {}
$@convention(witness_method: A2) <τ_0_0><τ_1_0 where τ_0_0 : K<τ_1_0>, τ_1_0 : C> (@in_guaranteed τ_0_0) -> ()
rdar://46173958
SR-9305